Skip to content

🧪 Q: [quality/testing improvement] Improve type-safety and fix translation tests#390

Open
pozar87 wants to merge 1 commit intomasterfrom
q-quality-boost-ngc-catalogs-i18n-11642641090270888267
Open

🧪 Q: [quality/testing improvement] Improve type-safety and fix translation tests#390
pozar87 wants to merge 1 commit intomasterfrom
q-quality-boost-ngc-catalogs-i18n-11642641090270888267

Conversation

@pozar87
Copy link
Owner

@pozar87 pozar87 commented Mar 7, 2026

This PR addresses several quality gaps identified during the audit:

  1. Type Safety: Resolved multiple reportAttributeAccessIssue and reportIncompatibleMethodOverride errors in the NGC and Catalogs modules.
  2. Robustness: Restored **kwargs to the NGC.get_visible override to ensure forward compatibility with the base Objects class.
  3. Correctness: Compiled all mission-critical translation files (.mo), which resolved 17 failing tests related to internationalization (i18n).
  4. Maintenance: Cleaned up unused imports using Ruff and refined the Pyright configuration to focus on core library code.

All 540 tests now pass with 0 type errors in the apts/ package.


PR created automatically by Jules for task 11642641090270888267 started by @pozar87

- Resolve pyright errors in `apts/objects/ngc.py` and `apts/catalogs.py`.
- Improve `NGC.get_visible` signature for Liskov compatibility.
- Compile `.mo` translation files to fix failing unit tests.
- Remove unused imports across the codebase.
- Configure pyright to ignore noisy test-file errors.

Co-authored-by: pozar87 <9629954+pozar87@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant