Conversation
- Implemented `field_rotation_rate` in `OpticalPath` using standard dq/dt formula. - Added `max_exposure_alt_az` to calculate max exposure time before field rotation blur exceeds a pixel tolerance. - Verified with unit tests for Seestar S50 and various sky positions. - Capped altitude at 89.99° to handle zenith singularities gracefully. - Updated Stellar's Journal with scientific references and benchmarks. Co-authored-by: pozar87 <9629954+pozar87@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR introduces field rotation calculations for Alt-Az mounts, a critical feature for users of smart telescopes and Alt-Az rigs.
field_rotation_rate(latitude, altitude, azimuth): Calculates the instantaneous rotation of the field of view in arcseconds per second. Uses the standard formula from Jean Meeus's Astronomical Algorithms.max_exposure_alt_az(latitude, altitude, azimuth, tolerance_px): Estimates the maximum exposure time allowed before the field rotation causes a blur larger than the specified pixel tolerance at the corner of the sensor.The implementation is verified with unit tests and includes handling for the zenith singularity. It provides immediate value for planning wide-field exposures on non-equatorial mounts.
PR created automatically by Jules for task 10370640079465511658 started by @pozar87