🌌 Oracle: Improved Conjunction precision and added Jovian Moon events#385
🌌 Oracle: Improved Conjunction precision and added Jovian Moon events#385
Conversation
- Implemented a two-pass search algorithm for Conjunctions and Lunar Occultations, achieving ±5 second timing precision. - Added a high-precision predictor for Jovian Moon events (Transits, Occultations, Shadows, and Eclipses) for Io, Europa, Ganymede, and Callisto. - Optimized kernel handling: the heavy Jovian satellite ephemeris (jup310.bsp) is now lazy-loaded and merged only when required. - Updated data preloading to optionally include the Jovian kernel. - Added comprehensive unit tests in tests/unit/test_oracle_precision.py and tests/unit/test_jovian_moons.py to verify event timing and logic. - Refined shadow/eclipse calculations to correctly use the Sun's perspective for topocentric observers. Co-authored-by: pozar87 <9629954+pozar87@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR significantly enhances the precision of celestial event predictions and adds a missing event type for Jovian moon phenomena.
Key improvements:
find_minima. Conjunctions and occultations are now accurate within seconds.jup310.bspkernel.get_jovian_ephemeris, ensuring no impact on standard operations unless Jovian events are specifically requested.PR created automatically by Jules for task 13654037187193466279 started by @pozar87