Skip to content

🧪 Q: Fix linting and type errors in equipment database and tests#384

Merged
pozar87 merged 1 commit intomasterfrom
q-quality-improvements-1510186142935215467
Mar 7, 2026
Merged

🧪 Q: Fix linting and type errors in equipment database and tests#384
pozar87 merged 1 commit intomasterfrom
q-quality-improvements-1510186142935215467

Conversation

@pozar87
Copy link
Owner

@pozar87 pozar87 commented Mar 6, 2026

Improved codebase health by resolving linting violations, fixing a type-checking error in tests, and adding missing test coverage for the equipment database loader. Specifically, it addresses E701 and F401 linting rules and ensures type safety when accessing optional members in tests.


PR created automatically by Jules for task 1510186142935215467 started by @pozar87

- Fix E701: Split one-line for loop in apts/equipment_database.py
- Fix F401: Remove unused imports in tests/unit/test_stellar_v5.py
- Fix reportOptionalMemberAccess: Add assert scale is not None in tests/unit/test_stellar_v5.py
- Add test_smart_telescope_loader to tests/unit/test_equipment_loader.py for better coverage

Co-authored-by: pozar87 <9629954+pozar87@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@pozar87 pozar87 merged commit 0ba9b18 into master Mar 7, 2026
1 check passed
@pozar87 pozar87 deleted the q-quality-improvements-1510186142935215467 branch March 7, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant