Conversation
- Updated Vaonis equipment database with manufacturer-verified specifications for Stellina, Vespera, Vespera II, Vespera Pro, and Hyperia. - Enhanced `SmartTelescope` class with comprehensive FOV methods (`field_of_view_width`, `field_of_view_height`, `field_of_view_diagonal`). - Added `_zoom_divider` to `SmartTelescope` for compatibility with `apts.optics` calculations. - Integrated `full_well` capacity support into `SmartTelescope`. - Added unit tests to verify accuracy and prevent regressions. Co-authored-by: pozar87 <9629954+pozar87@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This update significantly improves the accuracy and utility of the
aptslibrary for owners of Vaonis smart telescopes.Key improvements:
SmartTelescopeclass, providing width, height, and diagonal metrics._zoom_dividerand standard FOV signatures) to ensureSmartTelescopeobjects work seamlessly with the existingapts.opticspath analysis tools.Sources: Official Vaonis technical specifications (vaonis.com).
PR created automatically by Jules for task 16531587622318260388 started by @pozar87