Skip to content

Conversation

@sbonaime
Copy link
Contributor

Description of Change(s)

Adjust horizontal centering spacing for rest

Fixes Issue(s)

Fix #540

@cameronwhite
Copy link
Member

Thanks for looking at this!

While doing some testing I noticed that the new spacing didn't look as good for some durations like half rests, so perhaps the alignment needs some different settings per type

Screenshot 2025-11-22 at 10 18 24 PM

@sbonaime
Copy link
Contributor Author

sbonaime commented Nov 24, 2025

Maybe we should takie into account the width and height of each symbol before placing them. Or maybe at the drawing stage ?
Few examples were symbol width is important :

Tremolo picking
Capture d’écran 2025-11-24 à 10 59 30

Vibrato
Capture d’écran 2025-11-24 à 10 59 42

Large Vibrato and vibrato
Capture d’écran 2025-11-24 à 11 01 01

@cameronwhite
Copy link
Member

Yeah, there should ideally be some adjustments depending on the symbol

I recall it being hard to get accurate information about the width of each symbol from the Qt font info classes, which is why there are a lot of hardcoded scale factors in the layout code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rest position

2 participants