Conversation
d63f74b to
b1a395b
Compare
|
Hi! First and foremost, thank you for doing all this! It is really nice to have h3 integration in postgres :). I've been wondering that the h3 index structure fits perfectly the sp-gist indexes and found this PR. I tried to rebase this branch so it has the latest updates in main to give it a try and work on it. But it is a bit hell of a rebase 😁 and don't think I'm familiarized enough with your code to make it correctly. |
bc7870d to
e8aae9e
Compare
|
Hi @BielStela! Any help on this is appreciated, I've gone ahead and rebased the branch on main. You should be able to run the tests using the script at As far as I can tell the last test query is currently crashing the server. |
|
Hi, @zachasme, I managed to pass all the test by finding that the line was the one causing the segfault. I removed the pointer definition and fixed pass by reference here and there of |
|
Thank you for the fix! Yes, I'm afraid the current branch is simply the result of me smashing something together that can run on a PostgreSQL server. The next (big) step is figuring out how to best implement picksplit and choose, such that the implementation is both correct and performant. May I ask how you tested that the index is as slow as not having the index? |
80409b9 to
374c773
Compare
|
I'm going to wrap this up for |
Replaces #7. Part of #5.
I have closed the old PR which contained code for both GiST and SP-GiST, splitting it into two separate PRs.
Currently the tests do not pass, and work is focused GiST, see #42.