Check in Javascript if variables are set when initializing the module (#77) #78
Open
Paulsky wants to merge 1 commit intopostcode-nl:masterfrom
Open
Check in Javascript if variables are set when initializing the module (#77) #78Paulsky wants to merge 1 commit intopostcode-nl:masterfrom
Paulsky wants to merge 1 commit intopostcode-nl:masterfrom
Conversation
…nd this.settings are defined
Contributor
|
Hi Paulsky, While your PR does seem to get rid of errors as reported in #77, now the result is that field validation is missing when this.settings is not defined. This only works around the issue that settings are in some cases undefined. But for now it is not clear exactly how to reproduce the undefined settings. This needs to be known first so that we can test it. And more importantly, find the root cause and get it fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #77 Check in Javascript if childHouseNumberSelect and this.settings are defined