Skip to content

fix(prepull): Add toleration to run on tainted nodes #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amdove merged 1 commit into from
Feb 3, 2026
Merged

fix(prepull): Add toleration to run on tainted nodes #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions internal/controller/core/site_controller_pre_pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,15 @@ func deployPrePullDaemonset(ctx context.Context, r *SiteReconciler, req controll
},
},
},
// Universal toleration to run on all nodes regardless of taints
Tolerations: []v1.Toleration{
{
Operator: v1.TolerationOpExists,
},
},
},
},
}

if len(site.Spec.Workbench.Tolerations) > 0 {
// add the tolerations to the daemonset
for _, t := range site.Spec.Workbench.Tolerations {
prePullDaemonset.Spec.Template.Spec.Tolerations = append(prePullDaemonset.Spec.Template.Spec.Tolerations, *t.DeepCopy())
}

// TODO: should also use the workbench node selectors...? But could differ from Connect...
}
return nil
}); err != nil {
l.Error(err, "error creating or updating pre-pull daemonset")
Expand Down