Skip to content

fix(ci): push to GHCR on main branch before Docker Hub#33

Merged
ian-flores merged 1 commit intomainfrom
fix-dockerhub-repo-names
Jan 13, 2026
Merged

fix(ci): push to GHCR on main branch before Docker Hub#33
ian-flores merged 1 commit intomainfrom
fix-dockerhub-repo-names

Conversation

@ian-flores
Copy link
Contributor

Summary

The push-dockerhub job pulls from GHCR, but the image was only pushed to GHCR for PR builds. This adds a step to push to GHCR on main branch so push-dockerhub can pull and re-tag for Docker Hub.

Problem

On main branch:

  1. Build job creates image locally
  2. push-dockerhub job tries to docker pull from GHCR
  3. Image doesn't exist in GHCR → pull fails

Fix

Added "Push to GHCR (main branch)" step that runs before push-dockerhub job.

Test plan

  • Verify main branch build pushes to GHCR
  • Verify push-dockerhub job successfully pulls and pushes to Docker Hub

The push-dockerhub job pulls from GHCR, but the image was only
pushed to GHCR for PR builds. Added a step to push to GHCR on
main branch so push-dockerhub can pull and re-tag for Docker Hub.
@claude
Copy link

claude bot commented Jan 13, 2026

Claude finished @ian-flores's task —— View job


Review Complete

  • Read review guidelines
  • Analyze the workflow changes
  • Create and submit review

The fix correctly addresses the root cause where push-dockerhub job pulls from GHCR but the image was never pushed there on main branch. Change is minimal and well-placed.

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix correctly addresses the root cause: push-dockerhub job (line 200) pulls from GHCR (line 214), but the image was never pushed there on main branch.

The change is minimal and well-placed - it reuses the existing full-image output and runs right after GHCR login.

LGTM.

@ian-flores ian-flores marked this pull request as ready for review January 13, 2026 17:17
@ian-flores ian-flores merged commit c4288f2 into main Jan 13, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant