feat: add empty array integrations field to the manifest upon write-manifest#698
Closed
feat: add empty array integrations field to the manifest upon write-manifest#698
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
christierney
approved these changes
Aug 22, 2025
Collaborator
christierney
left a comment
christierney
left a comment
There was a problem hiding this comment.
Other than my typing question (which I may just be misunderstanding), looks pretty straightforward!
Contributor
Author
|
Seems like ci has been failing on main for a while so I don't think these failures have anything to do with me. Either way probably best not to merge this on a friday afternoon, so I'll hold off for now. |
Contributor
Author
|
Unnecessary given the friction downstream with shinyapps.io with this being a top level field and it breaking their validation. Addressed in issue: https://github.com/rstudio/lucid-server/issues/5564 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Add empty array "integrations" field to the manifest upon write-manifest. This is part of the work around auto-associating integrations with content upon deployment. See the main ticket for more information.
Fixes: #32761
Type of Change
Approach
ManifestIntegrationRequeststypemake_source_manifestcreate_voila_manifestas it is the only one that doesn't callmake_source_manifestinternally.Automated Tests
write_*_manifest_jsonfunctionmake_source_manifestmake testpassesChecklist