Add 6 high-priority E2E tests for redeployment, Quarto, multi-deploym…#3674
Draft
zackverham wants to merge 5 commits intomainfrom
Draft
Add 6 high-priority E2E tests for redeployment, Quarto, multi-deploym…#3674zackverham wants to merge 5 commits intomainfrom
zackverham wants to merge 5 commits intomainfrom
Conversation
…ent switching, file toggling, packages, and deployment status Addresses coverage gaps identified in E2E test analysis: - redeployment.cy.js: deploy, modify content, redeploy; verify same record reused - quarto-deployment.cy.js: Quarto document deployment with new fixture - multi-deployment-switching.cy.js: create two deployments, switch via picker - file-include-exclude.cy.js: toggle file checkboxes, verify TOML updates - package-management.cy.js: verify Python packages section shows detected packages - deployment-logs.cy.js: verify post-deploy status, View Content button, record fields Also adds modifyFileInContainer and countDeploymentRecordFiles custom commands and a quarto-doc content fixture (markdown-only, no Python/R engine). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The version skip is only needed when actually deploying to Connect (for requires-python support). These tests only create configs and interact with the sidebar UI, so they don't need the version gate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add resetCredentials() call before setAdminCredentials() so the credentials file is clean before appending. Without this, each spec file's before() hook appends a duplicate [credentials.admin-code-server] TOML table, causing the credential picker to fail after enough specs run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dotNomad
reviewed
Mar 9, 2026
Collaborator
dotNomad
left a comment
dotNomad
left a comment
There was a problem hiding this comment.
I think some of these will be able to be converted to more rigorous unit tests on the different components or parts of the code that do these things. Like file-include-exclude.cy.js I think we can verify that the checkboxes work with specific data, the data we get from our TS method is what we expect, and the TOML config reader gets that data.
Having said that though these are great tests to catch us while we are doing this migration.
If these pass CI I'm very happy to get them merged in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 6 new Cypress E2E tests covering the highest-priority gaps identified during test coverage analysis. Also adds supporting custom commands and a Quarto content fixture.
New Test Files
redeployment.cy.jsbundle_idchangesquarto-deployment.cy.jstype=quarto-static, files include_quarto.ymlmulti-deployment-switching.cy.jsfile-include-exclude.cy.jspackage-management.cy.jsrequirements.txtdeployment-logs.cy.jsSupporting Changes
test/e2e/support/commands.js— AddedmodifyFileInContainer()andcountDeploymentRecordFiles()custom commandstest/e2e/content-workspace/quarto-doc/— New fixture with_quarto.ymland a markdown-only.qmdfile (no Python/R engine dependency)Test plan
npx cypress run --spec tests/redeployment.cy.jsnpx cypress run --spec tests/quarto-deployment.cy.jsnpx cypress run --spec tests/multi-deployment-switching.cy.jsnpx cypress run --spec tests/file-include-exclude.cy.jsnpx cypress run --spec tests/package-management.cy.jsnpx cypress run --spec tests/deployment-logs.cy.jsjust devfromtest/e2e/requires-pythonsupport)🤖 Generated with Claude Code