-
Notifications
You must be signed in to change notification settings - Fork 6
refactor: read and write config toml in TypeScript #3662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christierney
wants to merge
27
commits into
main
Choose a base branch
from
chris/configurations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,671
−1,376
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
7ee6719
feat: add TypeScript TOML config loader and consolidate types
christierney f181b66
remove unnecessary type assertion
christierney 7e081b6
remove a couple other unneeded Record types
christierney fd817b6
refactor: loader throws ConfigurationLoadError instead of returning e…
christierney d055200
feat: add config writer, discovery, and compliance modules
christierney 13b0c2f
refactor: replace Go API config calls with TypeScript toml module
christierney 12e5565
fix: use relative projectDir in Configuration to match Go API convention
christierney 834a9b7
refactor: writeConfigToFile resolves paths internally from configName…
christierney 612a2ff
refactor: reduce toml barrel exports to public API surface only
christierney bd9ba78
fix: preserve empty section objects in stripEmpty to satisfy schema
christierney 866a827
fix: update stale error context strings to reference toml module func…
christierney a80fcd9
remove Go API handlers for configuration get/getAll/createOrUpdate
christierney 9be0e77
style: fix prettier formatting in state.test.ts
christierney 982a583
feat: skip __pycache__, renv, and packrat in recursive config discovery
christierney f789789
fix: format schema validation errors to match Go's output
christierney 955949c
fix: handle entrypointObjectRef in compliance and share formatValidat…
christierney ef8f13e
fix: filter redundant unevaluatedProperties errors using full key
christierney 7dfc4eb
fix: replace non-null assertions on workspaces.path() with defensive …
christierney 35dbd3a
perf: improve discovery.ts with parallel loading, fewer syscalls, and…
christierney f07d55d
refactor: reorder discovery.ts with public API first, private helpers…
christierney 36d1e2a
refactor: deduplicate Ajv schema setup into shared validate module
christierney df7025c
refactor: reduce error-wrapping boilerplate in loadConfigFromFile
christierney ed814e2
refactor: deduplicate convertKeys and reduce boilerplate in writer
christierney 836264a
fix: add missing await to satisfy require-await lint rule
christierney a7b0521
ci: pass debug_cypress input to e2e workflow from pull-request
christierney ae8edc6
fix: set productType when creating config via selectNewOrExistingConfig
christierney 25062f6
docs: add comment explaining loadConfigsFromPaths error handling
christierney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this!