Skip to content

feat: support setting externally created route table azure subnet #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtalbot merged 3 commits into from
Feb 27, 2026
Merged

feat: support setting externally created route table azure subnet #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0f3711
feat: support setting externally created route table on private azure…
timtalbot Feb 26, 2026
a7af92d
fix: undo unrelated change
timtalbot Feb 26, 2026
569c8b3
fix: undo unrelated change
timtalbot Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions lib/types/workload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,15 @@ type AzureWorkloadConfig struct {
}

type NetworkConfig struct {
VnetCidr string `yaml:"vnet_cidr"`
PublicSubnetCidr string `yaml:"public_subnet_cidr"`
PrivateSubnetCidr string `yaml:"private_subnet_cidr"`
DbSubnetCidr string `yaml:"db_subnet_cidr"`
NetAppSubnetCidr string `yaml:"netapp_subnet_cidr"`
AppGatewaySubnetCidr string `yaml:"app_gateway_subnet_cidr"`
ProvisionedVnetID string `yaml:"provisioned_vnet_id"`
VnetRsgName string `yaml:"vnet_rsg_name"`
VnetCidr string `yaml:"vnet_cidr"`
PublicSubnetCidr string `yaml:"public_subnet_cidr"`
PrivateSubnetCidr string `yaml:"private_subnet_cidr"`
PrivateSubnetRouteTableID string `yaml:"private_subnet_route_table_id"`
DbSubnetCidr string `yaml:"db_subnet_cidr"`
NetAppSubnetCidr string `yaml:"netapp_subnet_cidr"`
AppGatewaySubnetCidr string `yaml:"app_gateway_subnet_cidr"`
ProvisionedVnetID string `yaml:"provisioned_vnet_id"`
VnetRsgName string `yaml:"vnet_rsg_name"`
}

// AzureUserNodePoolConfig defines configuration for a single user node pool in AKS
Expand Down
1 change: 1 addition & 0 deletions python-pulumi/src/ptd/azure_workload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class NetworkConfig:
public_subnet_cidr: str | None = None
vnet_rsg_name: str | None = None
dns_forward_domains: list[dict[str, str]] = dataclasses.field(default_factory=list)
private_subnet_route_table_id: str | None = None

def __post_init__(self):
"""Validate DNS forward domain entries if configured."""
Expand Down
15 changes: 10 additions & 5 deletions python-pulumi/src/ptd/pulumi_resources/azure_workload_persistent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,6 @@ def _define_vnet(self):
resource_group_name=self.vnet_rsg_name,
virtual_network_name=self.vnet_name,
address_prefix=self.workload.cfg.network.private_subnet_cidr,
**(
{"nat_gateway": network.SubResourceArgs(id=self.nat_gw.id)}
if self.workload.cfg.network.public_subnet_cidr
else {}
),
service_endpoints=[
network.ServiceEndpointPropertiesFormatArgs(
locations=[self.workload.cfg.region],
Expand All @@ -193,6 +188,16 @@ def _define_vnet(self):
),
],
network_security_group=network.SubResourceArgs(id=private_nsg.id),
**(
{"nat_gateway": network.SubResourceArgs(id=self.nat_gw.id)}
if self.workload.cfg.network.public_subnet_cidr
else {}
),
**(
{"route_table": network.SubResourceArgs(id=self.workload.cfg.network.private_subnet_route_table_id)}
if self.workload.cfg.network.private_subnet_route_table_id
else {}
),
opts=pulumi.ResourceOptions(
parent=self.vnet if hasattr(self, "vnet") and self.vnet else None,
protect=self.workload.cfg.protect_persistent_resources,
Expand Down
Loading