-
Notifications
You must be signed in to change notification settings - Fork 135
Add session and code attribution for plots #11193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmcphers
wants to merge
33
commits into
main
Choose a base branch
from
feature/plots-attribution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This change adds a number of quality-of-life improvements to the Plots pane.
Session attribution
The Plots pane now has an indicator showing which session a plot was emitted from:
Clicking on this indicator will take you to the session's console, at the point in history where the plot was generated if possible.
Addresses #7031.
Code attribution
There is a new toolbar button containing actions dealing with the code used to generate the plot. This makes it easy to draw the plot again with new data, to refine the plot command, or to get context around the original plot command.
Note
The "code used to generate the plot" is considered to be the "the statement that was being executed when the plot appeared". Complicated plots are sometimes built over multiple statements, and capturing the exact set of statements used to generate a plot is not possible without a lot of semantic analysis and guesswork. We may invest in this in the future if it looks like it will be helpful.
Addresses #10183.
Plot naming
Each plot now has a unique name sent from the backend. These names can help distinguish plots that otherwise look similar in thumbnail views, and also provide more meaningful default titles when navigating, opening in editor tabs, or saving/exporting.
Filmstrip accessibility
The history filmstrip is now a lot more accessible.
<button>elements and also use the default focus outline decoration when focusedAddresses #3651.
Requires posit-dev/ark#998.
Release Notes
New Features
Bug Fixes
Xwith dark themes #3651)QA Notes
Test tags:
@:plots