Skip to content

Conversation

@nevrome
Copy link
Member

@nevrome nevrome commented Jan 16, 2026

My understanding of this mechanism is developing at a glacial speed, but today I made another breakthrough. I realized that I can replace cassava's FromField typeclass with my own. This allows to pass any desired piece of information down to the individual field parsers. For example the Poseidon version!

I think I can use this to solve some things that have been bugging me about #357.

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 35.32110% with 141 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.68%. Comparing base (0abb550) to head (fa035f8).
⚠️ Report is 10 commits behind head on poseidon300cols.

Files with missing lines Patch % Lines
src/Poseidon/Janno.hs 19.69% 2 Missing and 51 partials ⚠️
src/Poseidon/ColumnTypesJanno.hs 40.54% 12 Missing and 32 partials ⚠️
src/Poseidon/SequencingSource.hs 10.71% 0 Missing and 25 partials ⚠️
src/Poseidon/ColumnTypesSSF.hs 46.42% 2 Missing and 13 partials ⚠️
src/Poseidon/ColumnTypesUtils.hs 81.81% 0 Missing and 2 partials ⚠️
src/Poseidon/CLI/Validate.hs 50.00% 0 Missing and 1 partial ⚠️
src/Poseidon/Package.hs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           poseidon300cols     #364      +/-   ##
===================================================
- Coverage            57.34%   55.68%   -1.67%     
===================================================
  Files                   33       33              
  Lines                 5228     5237       +9     
  Branches               552      632      +80     
===================================================
- Hits                  2998     2916      -82     
- Misses                1678     1689      +11     
- Partials               552      632      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nevrome nevrome marked this pull request as ready for review January 18, 2026 13:20
@nevrome nevrome merged commit aa4e4db into poseidon300cols Jan 18, 2026
2 checks passed
@nevrome nevrome deleted the versionedcsvparsing branch January 18, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants