-
Notifications
You must be signed in to change notification settings - Fork 1
2025_Lazaridis_Yamnaya #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks, I can review this. |
stschiff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for contributing the package. Here is my review:
-
ID labels have
_IE. Why is this necessary? I can see that some individuals have been resequenced, but others are actually new. The labels used in Supplementary Table 1 in any case do not all have suffixes. -
The "Collection ID" is inconsistent. The Supplementary Table has a column named "Skeletal Code", which seems more appropriate (e.g. "Mos54 (Deriivka-1, burial 9)") than what is there currently, which looks more like a group name.
-
Relationship columns are impressively filled, lots of work, thanks!
-
C14-dates all entered, great! But calibration is missing!
|
|
Additional note: multiple individuals have no nuclear data. |
Adds/Updates
2025_Lazaridis_YamnayaLinked to poseidon-framework/minotaur-recipes#65
If this PR adds a new package to the archive, please note:
New packages added to the minotaur archive are always published in version
1.0.0.This means that any and all changes made to the package during the review process, should only bump the
MinororPatchversion of the package.PR checklist:
POSEIDON.ymlCountryinformation is also present in theCountry_ISOcolumn.n/ashould be removed from the janno.Y_Haplogroupswere provided in the ISOGG format, the column should be renamed toY_Haplogroups_ISOGGRelation_Tocolumn contain the_MNTsuffix.Once the Pull Request has passed the review process, ensure the package version is bumped once more before publishing with: