Add ability to set priorityClassName, annotations and imagePullPolicy #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on StorageCluster object
| | `updateStrategy.minReadySeconds` | Minimum number of seconds that a pod should be ready before the next batch of pods is updated during a rolling update | 1 | | ||
| | `updateStrategy.disruption.allow` | This field is used to enable or disable smart and parallel upgrade. Smart upgrade is disabled by default, Enable it by setting to false. we can use the `maxUnavailable` field to control the maximum number of Portworx nodes that can be upgraded at a time | None | | ||
| | `updateStrategy.autoUpdateComponents` | Specifies the update strategy for the component images. Valid values: None, Once, Always | None | | ||
| | `annotations` | Map of annotations to set on the StorageCluster object itself. | {} | |
Collaborator
There was a problem hiding this comment.
We don't have support to add annotations directly to the stc. However, most annotations are already supported in portworx chart. Which additional annotations are we want to set on the STC ?
Author
There was a problem hiding this comment.
Hi, we set the following annotations on the stc object:
# https://github.com/libopenstorage/operator/issues/354
# annotation needed to use tcr.paas.local as registry
operator.libopenstorage.org/common-image-registries: "gcr.io,k8s.gcr.io"
portworx.io/disable-storage-class: "true"
argocd.argoproj.io/sync-wave: "1"
# This resource doesn't exist yet on initial sync
argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
Mainly the first annotation is critical for us, to be able to use our own internal registry.
Collaborator
|
Please share the list of test cases or scenarios covered during testing |
Author
Test cases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds three parameters to the Portworx helm chart: