Skip to content

bug fix: centralized v8 mutex#55

Merged
eliasposen merged 3 commits intomainfrom
vec-panic
Feb 4, 2026
Merged

bug fix: centralized v8 mutex#55
eliasposen merged 3 commits intomainfrom
vec-panic

Conversation

@eliasposen
Copy link
Contributor

@eliasposen eliasposen commented Feb 4, 2026

Description

Fixed JS runtime race condition by moving the V8 mutex to be held for the entire typecheck/execute process.

Related Issues

Fixes #
Related to #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test coverage improvement

Changes Made

  • Centralized V8 mutex

Testing

  • added test_concurrent_execute_stress which recreates this scenario

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Commands Run

cargo test
cargo clippy
cargo fmt --check

Breaking Changes

  • This PR includes breaking changes
  • Migration guide updated in CHANGELOG.md

Documentation

  • Code comments added/updated
  • README.md updated (if needed)
  • CHANGELOG.md updated under "Unreleased"
  • API documentation updated

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots/Videos

Additional Context

@pk8189 pk8189 changed the title bug fix: cetralized v8 mutex bug fix: centralized v8 mutex Feb 4, 2026
@eliasposen eliasposen marked this pull request as ready for review February 4, 2026 22:15
@eliasposen eliasposen merged commit f1b3a91 into main Feb 4, 2026
4 checks passed
@eliasposen eliasposen deleted the vec-panic branch February 4, 2026 22:31
@eliasposen eliasposen restored the vec-panic branch February 4, 2026 22:34
@eliasposen eliasposen mentioned this pull request Feb 4, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant