Skip to content

Improved Code Generation for no args / all optional args#54

Merged
eliasposen merged 4 commits intomainfrom
empty-args
Feb 4, 2026
Merged

Improved Code Generation for no args / all optional args#54
eliasposen merged 4 commits intomainfrom
empty-args

Conversation

@eliasposen
Copy link
Contributor

Description

Improved code generation for no args / all optional args

Related Issues

Fixes #53

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test coverage improvement

Changes Made

  • pctx_codegen no longer requires an input schema. Previous temp fix was to default to any, now input arguments are skipped all together
  • Better default support for maps & input objects with all optional props in pctx_codegen.
  • Snapshotting testing framework for tools

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Commands Run

cargo test
cargo clippy
cargo fmt --check

Breaking Changes

Breaking changes for pctx_codegen crate but not for others/CLI

Documentation

  • Code comments added/updated
  • README.md updated (if needed)
  • CHANGELOG.md updated under "Unreleased"
  • API documentation updated

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots/Videos

Additional Context

Copy link
Collaborator

@pk8189 pk8189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliasposen eliasposen merged commit bf72e21 into main Feb 4, 2026
9 checks passed
@eliasposen eliasposen deleted the empty-args branch February 4, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improved Handling of missing & all optional input schemas

2 participants