Feature/ReadonlyFormField and ReadonlyFormFieldWrapper refactoring #222
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import { Component, DebugElement } from '@angular/core'; | ||
| import { ReadOnlyFormFieldWrapperComponent } from './readonly-form-field-wrapper.component'; | ||
| import { ReadOnlyFormFieldComponent } from '../readonly-form-field/readonly-form-field.component'; | ||
| import { FormControl, FormGroup, FormGroupDirective, FormsModule, ReactiveFormsModule } from '@angular/forms'; | ||
| import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
| import { By } from '@angular/platform-browser'; | ||
| import { ReadOnlyFormFieldModule } from '../readonly-form-field.module'; | ||
| import { MatFormFieldModule } from '@angular/material/form-field'; | ||
| import { MatInput } from '@angular/material/input'; | ||
| import { NoopAnimationsModule } from '@angular/platform-browser/animations'; | ||
|
|
||
| @Component({ | ||
| template: ` | ||
| <form [formGroup]="form"> | ||
| <mad-readonly-form-field-wrapper [readonly]="readonly" [value]="value"> | ||
| <mat-form-field> | ||
| <mat-label>Test Label</mat-label> | ||
| <input formControlName="test" matInput /> | ||
| </mat-form-field> | ||
| </mad-readonly-form-field-wrapper> | ||
| </form> | ||
| `, | ||
| standalone: true, | ||
| imports: [ReadOnlyFormFieldModule, MatFormFieldModule, FormsModule, ReactiveFormsModule, MatInput], | ||
| }) | ||
| class WrapperTestHostComponent { | ||
| readonly = true; | ||
| value = 'Test Value'; | ||
| form = new FormGroup({ test: new FormControl('Initial Value') }); | ||
| } | ||
|
|
||
| describe('ReadOnlyFormFieldWrapperComponent', () => { | ||
| let fixture: ComponentFixture<WrapperTestHostComponent>; | ||
| let hostComponent: WrapperTestHostComponent; | ||
| let wrapperDebugEl: DebugElement; | ||
|
|
||
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({ | ||
| imports: [WrapperTestHostComponent, NoopAnimationsModule], | ||
| providers: [FormGroupDirective], | ||
| }).compileComponents(); | ||
|
|
||
| fixture = TestBed.createComponent(WrapperTestHostComponent); | ||
| hostComponent = fixture.componentInstance; | ||
| wrapperDebugEl = fixture.debugElement; | ||
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should create the host and wrapper component', () => { | ||
| expect(hostComponent).toBeTruthy(); | ||
| const wrapper = wrapperDebugEl.query(By.directive(ReadOnlyFormFieldWrapperComponent)); | ||
| expect(wrapper).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should render readonly component when readonly is true', () => { | ||
| const readonlyField = wrapperDebugEl.query(By.directive(ReadOnlyFormFieldComponent)); | ||
| expect(readonlyField).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should render projected content when readonly is false', () => { | ||
| hostComponent.readonly = false; | ||
| fixture.detectChanges(); | ||
| const input = wrapperDebugEl.query(By.css('input')); | ||
| expect(input).toBeTruthy(); | ||
| expect(input.nativeElement.value).toBe('Initial Value'); | ||
| }); | ||
|
|
||
| it('should emit suffixClickedEmitter', () => { | ||
| const wrapperInstance = wrapperDebugEl.query(By.directive(ReadOnlyFormFieldWrapperComponent)).componentInstance; | ||
| jest.spyOn(wrapperInstance.suffixClickedEmitter, 'emit'); | ||
| wrapperInstance.suffixClicked(); | ||
| expect(wrapperInstance.suffixClickedEmitter.emit).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should emit prefixClickedEmitter', () => { | ||
| const wrapperInstance = wrapperDebugEl.query(By.directive(ReadOnlyFormFieldWrapperComponent)).componentInstance; | ||
| jest.spyOn(wrapperInstance.prefixClickedEmitter, 'emit'); | ||
| wrapperInstance.prefixClicked(); | ||
| expect(wrapperInstance.prefixClickedEmitter.emit).toHaveBeenCalled(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| import { ReadOnlyFormFieldComponent } from './readonly-form-field.component'; | ||
| import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
| import { NumberFormatService } from '../../numeric-field/number-format.service'; | ||
| import { ChangeDetectorRef, ElementRef, Renderer2 } from '@angular/core'; | ||
| import { NoopAnimationsModule } from '@angular/platform-browser/animations'; | ||
| import { By } from '@angular/platform-browser'; | ||
|
|
||
| describe('ReadOnlyFormFieldComponent', () => { | ||
| let component: ReadOnlyFormFieldComponent; | ||
| let fixture: ComponentFixture<ReadOnlyFormFieldComponent>; | ||
| let numberFormatService: NumberFormatService; | ||
|
|
||
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({ | ||
| imports: [ReadOnlyFormFieldComponent, NoopAnimationsModule], | ||
| providers: [ | ||
| NumberFormatService, | ||
| Renderer2, | ||
| ChangeDetectorRef, | ||
| { provide: ElementRef, useValue: new ElementRef(document.createElement('div')) }, | ||
| ], | ||
| }).compileComponents(); | ||
|
|
||
| fixture = TestBed.createComponent(ReadOnlyFormFieldComponent); | ||
| component = fixture.componentInstance; | ||
| numberFormatService = TestBed.inject(NumberFormatService); | ||
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should create', () => { | ||
| expect(component).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should fallback to dash if value is not set', () => { | ||
| component.value = undefined; | ||
| component.ngOnChanges({}); | ||
| expect(component.value).toBe('-'); | ||
| }); | ||
|
|
||
| it('should format number if formatNumber is true', () => { | ||
| const spy = jest.spyOn(numberFormatService, 'format').mockReturnValue('1,234.00'); | ||
| component.value = 1234; | ||
| component.formatNumber = true; | ||
| component.ngOnChanges({}); | ||
| expect(spy).toHaveBeenCalled(); | ||
| expect(component.value).toBe('1,234.00'); | ||
| }); | ||
|
|
||
| it('should emit suffixClickedEmitter when suffix icon is clicked', () => { | ||
| const spy = jest.spyOn(component.suffixClickedEmitter, 'emit'); | ||
| component.suffix = 'info'; | ||
| fixture.detectChanges(); | ||
| const suffixIcon = fixture.debugElement.query(By.css('[data-cy="suffix-icon"]')); | ||
| suffixIcon.triggerEventHandler('click'); | ||
| expect(spy).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should emit prefixClickedEmitter when prefix icon is clicked', () => { | ||
| const spy = jest.spyOn(component.prefixClickedEmitter, 'emit'); | ||
| component.prefix = 'info'; | ||
| fixture.detectChanges(); | ||
| const prefixIcon = fixture.debugElement.query(By.css('[data-cy="prefix-icon"]')); | ||
| prefixIcon.triggerEventHandler('click'); | ||
| expect(spy).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should compute tooltip text correctly for unit position right', () => { | ||
| component.value = 123; | ||
| component.unit = '%'; | ||
| component.unitPosition = 'right'; | ||
| const tooltip = component['calculateToolTipText'](); | ||
| expect(tooltip).toBe('123 %'); | ||
| }); | ||
|
|
||
| it('should compute tooltip text correctly for unit position left', () => { | ||
| component.value = 123; | ||
| component.unit = '$'; | ||
| component.unitPosition = 'left'; | ||
| const tooltip = component['calculateToolTipText'](); | ||
| expect(tooltip).toBe('$ 123'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and everywhere else: I think we should use
instead :)