add EH-expansion-evaluator tool as a docker image#96
Open
htanudisastro wants to merge 15 commits intomainfrom
Open
add EH-expansion-evaluator tool as a docker image#96htanudisastro wants to merge 15 commits intomainfrom
htanudisastro wants to merge 15 commits intomainfrom
Conversation
Contributor
Author
|
Let me know if there's a better way to do this, this is my first time making a Docker image out of something that's not a binary on Git. |
MattWellie
reviewed
Sep 10, 2023
MattWellie
requested changes
Sep 10, 2023
Contributor
MattWellie
left a comment
MattWellie
left a comment
There was a problem hiding this comment.
The cd you've included here will only change the CWD during the build process - to make this permanent (i.e. each time you run the Docker image) you need to use the WORKDIR keyword
Co-authored-by: Matt Welland <mattwellie@gmail.com>
jmarshall
reviewed
Sep 10, 2023
| @@ -0,0 +1,17 @@ | |||
| FROM ubuntu:20.04 | |||
Contributor
There was a problem hiding this comment.
This is pretty old by now.
Suggested change
| FROM ubuntu:20.04 | |
| FROM ubuntu:22.04 |
jmarshall
reviewed
Sep 10, 2023
MattWellie
requested changes
Sep 10, 2023
Co-authored-by: John Marshall <john.marshall@populationgenomics.org.au>
Co-authored-by: John Marshall <john.marshall@populationgenomics.org.au>
Co-authored-by: Matt Welland <mattwellie@gmail.com>
Co-authored-by: Matt Welland <mattwellie@gmail.com>
Contributor
Author
|
linting errors are going a bit crazy, checking other files in the repo. But I think I've fixed the necessary linting changes. |
Co-authored-by: Matt Welland <mattwellie@gmail.com>
MattWellie
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.