Conversation
lgruen-vcgs
approved these changes
Mar 14, 2026
- Rename types.py -> anchors.py to avoid shadowing stdlib `types` module - Replace all direct class/function imports with module-qualified references throughout internal modules (anchors.Anchor, providers.MarkdownProvider, bbox_alignment.align_anchors, etc.) - Add module docstrings to all source files - Replace assert with explicit RuntimeError in range_ops sweep-line invariant - Expand chunks() docstring with Args/Yields/Raises sections - Add Args section to align() docstring - Use abstract types in public signatures: Sequence/Mapping over list/dict - Update test_regression.py to use public API (anchorite.Anchor, anchorite.document) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
folded
force-pushed
the
enforce-pystyle
branch
2 times, most recently
from
7bf21ee to
45001fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
types.py→anchors.pyto avoid shadowing the stdlibtypesmodule; establishesanchors.Anchor/anchors.BBoxas the unambiguous internal reference pathanchors.Anchor,providers.MarkdownProvider,bbox_alignment.align_anchors, etc.)assertwith explicitRuntimeErrorinrange_opssweep-line invariant checkchunks()docstring with Args/Yields/Raises; adds Args toalign()Sequence/Mappingoverlist/dict)test_regression.pyto use the public API (anchorite.Anchor,anchorite.document) rather than internal submodule pathsTest plan
🤖 Generated with Claude Code