Add userTracking toggle#654
Open
simofacc wants to merge 32 commits intopopcorn-time:masterfrom
simofacc:master
Open
Add userTracking toggle#654simofacc wants to merge 32 commits intopopcorn-time:masterfrom simofacc:master
simofacc wants to merge 32 commits intopopcorn-time:masterfrom
simofacc:master
Conversation
Add enableUserTracking boolean to app.js to easily turn tracking on and off.
On some system it seems like default css directory is `stylesheet` instead of `css`.
|
I started adding a settings page (#660). Perhaps this could be added there as well. |
Author
|
If we want to let the user choose if he wants to be tracked or not then it's fine, but otherwise it might not be needed. In any case you should use a checkbox with the label "Help us improve the application" or something like that since the tracking is mainly used to track user actions. |
|
I believe it is a good practise to let the user knows his action are tracked by default and giving people the option to opt-out is quite important in my opinion. Especially in the case of Popcorntime where not everyone might like the fact they are sending usage data about illegal copyright infringment... |
Author
|
Yes I agree completely. |
Translate interface string to the Maltese language Add maltese flag to the images folder and in the css code
Conflicts: index.html js/frontend/controllers/search.js
removing old popcorntime repository references
Fix search and add support for larger images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add enableUserTracking boolean to app.js to easily turn tracking on and
off.
Related to #226