Open
Conversation
Incorporate Worldborderrenderer changes across all mods update serverWorld() to world() and serverLevel() to level() Bump versioning and required versions Change NeoForge ServerGamePacketListenerImplMixin.java to ServerPlayerMixin due to changes to teleport classes
pop4959
reviewed
Jun 30, 2025
Owner
pop4959
left a comment
pop4959
left a comment
There was a problem hiding this comment.
Few minor things after taking an initial glance over the PR. Haven't looked closely at WorldBorderRenderer yet as I would like to compare this later to the vanilla code.
Also, if possible, please adhere to the existing code style as this makes things much easier to review especially in terms of reducing unnecessary diff. E.g. changing line/file endings, changing code indentation, adding/removing 'final' or other keywords, etc.
| ], | ||
| "depends": { | ||
| "fabricloader": ">=0.16.7", | ||
| "fabricloader": ">=0.16.12", |
Owner
There was a problem hiding this comment.
Suggested change
| "fabricloader": ">=0.16.12", | |
| "fabricloader": ">=0.16.14", |
14?
| private boolean initialized; | ||
|
|
||
| public ChunkyBorderForge() { | ||
| public ChunkyBorderForge(net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext context) { |
Owner
There was a problem hiding this comment.
Any reason this isn't just an import?
|
|
||
| public ChunkyBorderForge() { | ||
| public ChunkyBorderForge(net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext context) { | ||
| var modBusGroup = context.getModBusGroup(); |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate Worldborderrenderer changes across all mods
Update serverWorld() to world() and serverLevel() to level()
Bump versioning and required versions
Change NeoForge ServerGamePacketListenerImplMixin.java to ServerPlayerMixin due to changes to teleport classes
Make changes to incorporate Forge Eventbus 7 changes