Prevent block breaks outside the border#93
Merged
pop4959 merged 1 commit intopop4959:masterfrom Aug 12, 2025
Merged
Conversation
pop4959
approved these changes
Mar 20, 2025
Owner
pop4959
left a comment
There was a problem hiding this comment.
Looks good to me, tentatively, but will wait on merging until I have time to test this.
ab5f33a to
dda131c
Compare
pop4959
reviewed
Aug 12, 2025
Owner
pop4959
left a comment
There was a problem hiding this comment.
Looks good, pending testing, although one question: I notice there is some work done towards parity here with the various events on Fabric/Forge/Neo. This is great, however I did notice Fabric seems to be missing a place event handler. Was this overlooked, or some issue with impl there?
Contributor
Author
|
I couldn't find a simple way to accomplish it in fabric, so I left it out of this one hoping that somebody with better knowledge in that area might add it in the future. I've tested this on fabric/forge/neoforge now and they all pass, I did the following steps each time:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
Adds a block break event and implements it on all platforms, tested it on bukkit but not the others.
I noticed that other platforms were missing the place event so I added it to (neo)forge, couldn't find a simple way to implement it on fabric.