Fix compatibility with ServerReplay#92
Merged
pop4959 merged 2 commits intopop4959:masterfrom Mar 9, 2025
senseiwells:master
Merged
Fix compatibility with ServerReplay#92pop4959 merged 2 commits intopop4959:masterfrom senseiwells:master
pop4959 merged 2 commits intopop4959:masterfrom
senseiwells:master
Conversation
pop4959
requested changes
Mar 9, 2025
Owner
pop4959
left a comment
pop4959
left a comment
There was a problem hiding this comment.
Just one nitpick but otherwise fine! Thanks for the PR!
bukkit/src/main/java/org/popcraft/chunkyborder/ChunkyBorderBukkit.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue that ServerReplay has with BorderPayloads causing
NullPointerExceptions, since BorderPayloads were never intended to be read in then written back out. This PR fixes this by removing the 2 possible states the payload can be in and merging them into one.The user that reported the bug confirmed that this fixes the issue.