Merged
Conversation
Owner
|
Some initial comments & requests:
Aside from that, the changes here look generally good to me at a glance. Thanks for cooking this draft up. |
pop4959
reviewed
Aug 12, 2025
| playerData.setLastLocation(location); | ||
| } else if (!player.hasPermission("chunkyborder.bypass.move") && !playerData.isBypassing()) { | ||
| final Location redirect; | ||
| } else if (!playerData.isBypassing() && !player.hasPermission("chunkyborder.bypass.move")) { |
pop4959
reviewed
Aug 12, 2025
Owner
|
Thanks for addressing my comments, this is more in-line with what I was expecting for a refactor in this part of the code. Pending the merging of pop4959/Chunky#424 this looks good. |
9f3425e to
c6e3725
Compare
pop4959
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes wrapping on folia by using getElevation non-blockingly, and as a free bonus, prevents doing a sync chunk load on paper servers.