Skip to content

i18n(nl) add and update Dutch translation #227

Merged
jacobgkau merged 4 commits intopop-os:masterfrom
phoekjelle:master
Feb 10, 2025
Merged

i18n(nl) add and update Dutch translation #227
jacobgkau merged 4 commits intopop-os:masterfrom
phoekjelle:master

Conversation

@phoekjelle
Copy link
Contributor

No description provided.

@jacobgkau jacobgkau requested a review from a team January 7, 2025 16:23
@jacobgkau jacobgkau self-assigned this Jan 7, 2025
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new translations are showing up as expected in a user account set to Dutch.

Not sure why the Noble builds failed, but they also failed on #222, so it seems unlikely to be caused by this PR in particular.

@jacobgkau jacobgkau requested a review from a team January 7, 2025 20:14
@phoekjelle
Copy link
Contributor Author

Is it now better?

@jacobgkau
Copy link
Member

jacobgkau commented Jan 8, 2025

You did not need to make any additional changes. I had approved the PR and stated that the issue was not part of your PR.

Edit: Looks like removing that last comment did not affect the failing builds (as expected). I'll redo a quick QA check to approve again.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation's still working as expected on e207761.

@phoekjelle
Copy link
Contributor Author

What is the status of this PR right now?

@phoekjelle phoekjelle changed the title add and update Dutch translation i18n(nl) add and update Dutch translation Jan 22, 2025
@jacobgkau jacobgkau merged commit bbeb423 into pop-os:master Feb 10, 2025
10 of 12 checks passed
@phoekjelle
Copy link
Contributor Author

Does this work, or do I need to re-base?

I can re-base easyly

@jacobgkau
Copy link
Member

We already merged it, it worked fine like I stated in both #227 (review) and #227 (review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants