Revert: session: Add custom dconf profile#160
Open
City-busz wants to merge 1 commit intopop-os:masterfrom
Open
Revert: session: Add custom dconf profile#160City-busz wants to merge 1 commit intopop-os:masterfrom
City-busz wants to merge 1 commit intopop-os:masterfrom
Conversation
This commit reverts 87a0644. Setting a custom profile for the COSMIC session causes that all apps launched in it save their settings into this custom profile rather than the into main user profile, so these settings are lost when the user logs in into a different desktop environment. Since the custom gtk.css is cleaned up on exit, and the GTK theme override is an optional feature, it should be safe to use the main dconf profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reverts #90.
Setting a custom profile for the COSMIC session causes that all apps launched in it save their settings into this custom profile rather than the into main user profile, so these settings are lost when the user logs in into a different desktop environment.
Since the custom
gtk.cssis cleaned up on exit, and the GTK theme override is an optional feature, it should be safe to use the main dconf profile.To avoid overwriting the
icon-themeandbutton-layoutGSettings properties on login by default, I proposed two solutions: