Add option to stop mining after finding X blocks #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cculianu
reviewed
Aug 23, 2020
| break; | ||
| case 'X': | ||
| v = atoi(arg); | ||
| if (v < -1) /* sanity check */ |
There was a problem hiding this comment.
atoi returns 0 on failure. You may want to detect that case here.
cculianu
reviewed
Aug 23, 2020
| s, | ||
| result ? "(yay!!!)" : "(booooo)"); | ||
|
|
||
| if (accepted_count >= opt_max_blocks) { |
There was a problem hiding this comment.
This relies on subtleties of comparing signed and unsigned in C. You may want to make this code more explicit by doing e.g.:
if (opt_max_blocks > 0 && accepted_count >= opt_max_blocks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can come in handy for testing when needing to only mine a certain amount of blocks without babysitting the console