Conversation
Suzie97
commented
Jul 5, 2021
| }; | ||
| headerbar.get_style_context ().add_class (Gtk.STYLE_CLASS_FLAT); | ||
| headerbar.get_style_context ().add_class ("default-decoration"); | ||
|
|
Author
There was a problem hiding this comment.
The Granite.Widgets.Welcome widget was not used here because it uses a slightly darker background color which is not the same as the flat headerbar color. So it doesn't look like as if the headerbar is part of the window itself.
Owner
pongloongyeat
left a comment
pongloongyeat
left a comment
There was a problem hiding this comment.
Saw code, haven't actually compiled. I've made a vala-rewrite branch so when your PR is out of draft, you can request for this PR to be merged in there in the meantime.
Co-authored-by: Pong Loong Yeat <pongloongyeat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the UI part of the vala rewrite of the app, and also installs the icon, and appdata.
I'm sorry I'm new to PRs and other things, so I don't know a lot. I don't have access create a branch in the repo so I'm directly opening a draft PR on master.