Replaced regexp lookahead with two regular expressions#2
Open
romanoff wants to merge 2 commits intopomack:masterfrom
Open
Replaced regexp lookahead with two regular expressions#2romanoff wants to merge 2 commits intopomack:masterfrom
romanoff wants to merge 2 commits intopomack:masterfrom
Conversation
Owner
|
Cool, I can't really look at this for a couple weeks, but will definitely want this merged. I couldn't quite understand what the regexp was doing to re-write it. The regexp was taken from the Java code. |
Author
|
No problem. I will wait :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea is that I replaced
"^(?!-_(?:expression|(?:moz-)?binding))(?:[.#]?-?(?:[_a-z0-9-]+)(?:-[a-z0-9-]+)-?|-?(?:[0-9]+(?:.[0-9]*)?|.[0-9]+)(?:[a-z]{1,2}|%)?|!important|)\z/i"
regexp with:
"^(-_(?:expression|(?:moz-)?binding))/i" (it should not match)
"(?:[.#]?-?(?:[_a-z0-9-]+)(?:-[a-z0-9-]+)-?|-?(?:[0-9]+(?:.[0-9]*)?|.[0-9]+)(?:[a-z]{1,2}|%)?|!important|)\z/i" (it should match).
Probably it's good idea to look on second commit only. As first one is just "go fmt". Tests pass now.