GitHub action #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been trying to build locksmith with the pinned versions of CIL and Banshee here. This pull request sets up an action that builds locksmith on github's
ubuntu-22.04image. On my fork, the build succeeds using the older banshee, but here something goes wrong. After some changes (reverting 67658e3), locksmith compiles and can be executed, but it doesn't terminate on my machine. The simple test doesn't work on the CI either.I hope you can find some time to make sure locksmith builds on modern machines. Race detection for real-world C programs is still a difficult problem, and I don't fully trust any single analyzer on complicated programs. It's very useful to be able to compare the verdict of different analyzers!