Skip to content

[:recycle:] Eliminate unneeded coupling with zipFile :coffin: #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JJ merged 1 commit into from
Oct 17, 2022
Merged

[:recycle:] Eliminate unneeded coupling with zipFile :coffin: #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions feature-utils/poly-import/utils/zipfile-mock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import { jsonStringifyWithUtfEscape } from "./json-encoding";
//The minimum size of a .ZIP file is 22 bytes
export const MINIMUM_FILE_SIZE = 22;
export class ZipFileEntryMock {
constructor(zipFile, id, path, content) {
this.zipFile = zipFile;
constructor(id, path, content) {
this._id = id;
this._path = path;
this.content = content;
Expand All @@ -18,12 +17,11 @@ export class ZipFileEntryMock {
}

async stat() {
const entryContent = this.zipFile.entries[this._id];
return {
getId: () => this._id,
getTime: () => "",
getName: () => this._id.substr(this.zipFile.id.length),
getSize: () => entryContent.length,
getName: () => this._path,
getSize: () => this.content.length,
isFile: () => true,
isDirectory: () => false,
};
Expand Down Expand Up @@ -70,12 +68,7 @@ export class ZipFileMock {

addNamedEntry(fileName, stringContent) {
const entryId = this.id + "/" + fileName;
const entry = new ZipFileEntryMock(
this,
entryId,
fileName,
stringContent
);
const entry = new ZipFileEntryMock(entryId, fileName, stringContent);
this._entriesPathHash.set(fileName, entry);
}

Expand Down