Update DdlManagerImpl.java to support the SQL-based creation of views in a document namespace#444
Open
MinZhangData wants to merge 2 commits intopolypheny:masterfrom
Open
Update DdlManagerImpl.java to support the SQL-based creation of views in a document namespace#444MinZhangData wants to merge 2 commits intopolypheny:masterfrom
MinZhangData wants to merge 2 commits intopolypheny:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I modified the checkModelLangCompatibility method in the DdlManagerImpl class to support the SQL-based creation of views in a document namespace.
Fixes: #ABC, #XYZ [link all relevant issues]
Changes
I have added a new conditional statement in the checkModelLangCompatibility method to prevent a RuntimeException from being thrown. As I am not very experienced with git operations, I inadvertently included an extra blank line in the submission.:)
Features
Support the SQL-based creation of views in a document namespace.
Bug Fixes
All related Bug fixes
Tests
Summarize the introduced test capabilities for your feature.
ToDo