Midhun/fix extension: Fix DuckDB v1.4.2 compatibility#64
Merged
Conversation
- Migrated to ExtensionLoader API (LoadInternal, DUCKDB_CPP_EXTENSION_ENTRY) - Updated docker-demo to use DuckDB v1.4.2 - Added todo.md for Ubuntu verification Addresses GitHub issue #63
- Updated Load method signature from ExtensionLoader to DuckDB &db - Changed to use ExtensionUtil::RegisterFunction instead of loader.RegisterFunction - Updated extern C entry point to use new API - Added build dependencies to Dockerfile (git, cmake, ninja, ccache) - Created docker-compose.yml for easier development workflow - Added test_verification.sql for testing - Updated README with verification instructions
- Changed from v1.1.0 to v1.4.0 to match extension API compatibility - Updated extension-ci-tools reference to @v1.4.0 - This ensures CI tests the correct API version
- Added Version() method declaration in header - Added Version() method implementation - Fixes 'marked override but does not override' error - Completes DuckDB v1.4.0 Extension API migration
- Changed from v1.1.0-migration to v1.4.0 - Required for Extension API compatibility
- Update MainDistributionPipeline.yml to use v1.4.2 instead of v1.4.0 - This matches the version in the duckdb submodule and Dockerfile
Contributor
|
@midhun-TUB Great stuff! 😊 If it makes sense, please consider creating a PR on https://github.com/duckdb/community-extensions that replaces me with yourself as the maintainer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple issues to ensure compatibility with DuckDB v1.4.2:
Changes
Testing