Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 13, 2025

Implementation Complete: Redis Consumer Group Support with XACK

✅ All Tasks Completed

  • Update RedisSource class to require and use consumer groups for Redis Streams
  • Update configuration classes to support consumer group parameters
  • Update example configuration files to include consumer group
  • Update tests to validate consumer group functionality
  • Update documentation (README.md and USAGE.md)
  • Run linting and tests to ensure all changes work correctly
  • Fix black formatting issues

Recent Updates

Commit: Fix black formatting issues

  • Applied black formatter to src/fs_data_sink/config/settings.py
  • Applied black formatter to tests/unit/test_redis_source.py
  • All formatting now complies with project standards
  • All 34 tests still passing

Testing & Quality

  • 34/34 tests passing (100% pass rate)
  • Black formatting: Clean (0 files need reformatting)
  • Ruff linting: All checks passed
  • 0 security vulnerabilities (CodeQL scan clean)
  • ✅ Code coverage: 87% for redis_source.py

Summary

Successfully implemented Redis consumer group support with XREADGROUP and XACK. All linting and formatting issues have been resolved.

Original prompt

This section details on the original issue you should resolve

<issue_title>Require consumer group in redis stream and use XACK when consume</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits November 13, 2025 03:10
Co-authored-by: slhmy <31381093+slhmy@users.noreply.github.com>
Co-authored-by: slhmy <31381093+slhmy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add consumer group support in Redis stream with XACK Require consumer group for Redis Streams and use XREADGROUP/XACK Nov 13, 2025
Copilot AI requested a review from slhmy November 13, 2025 03:22
@slhmy
Copy link
Contributor

slhmy commented Nov 13, 2025

@copilot Fix possible format and Lint ISSUES

Run black --check src/ tests/
would reformat /home/runner/work/fs-data-sink/fs-data-sink/src/fs_data_sink/config/settings.py
would reformat /home/runner/work/fs-data-sink/fs-data-sink/tests/unit/test_redis_source.py

Oh no! 💥 💔 💥
2 files would be reformatted, 22 files would be left unchanged.

Co-authored-by: slhmy <31381093+slhmy@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 13, 2025

@copilot Fix possible format and Lint ISSUES

Run black --check src/ tests/

...

Fixed in ac57141. Applied black formatter to both files - all formatting checks now pass.

@slhmy slhmy marked this pull request as ready for review November 13, 2025 06:23
@slhmy slhmy merged commit c388e6d into main Nov 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require consumer group in redis stream and use XACK when consume

2 participants