Swift 4 support #24
Open
Swift 4 support #24
+29
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey guys, could you take a look on this branch? It would be nice to have it updated to Swift 4 |
JoniVR
approved these changes
Oct 9, 2017
JoniVR
left a comment
JoniVR
left a comment
There was a problem hiding this comment.
Tested this on iOS 11.0, working perfectly.
Only still has the yellow warnings indicating that the "Swift 3 objc inference" setting in build settings still needs to be set to "Default" which is an easy change.
Author
|
Fixed! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Here's a quick change that makes it Swift 4 compatible. Would it be possible to create a new Swift 4 branch?