-
-
Notifications
You must be signed in to change notification settings - Fork 39
Add 3.14 (fix #113) #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.14 (fix #113) #114
Conversation
|
502 caused the tests to fail, which is weird. I heard there's some large AWS outage today, so I'll come back to this. |
|
Hm, it looks like just re-running the tests fixed things, so if someone can confirm the test release works I can make a real release. |
|
On Fedora 43 beta, I had to install mecab-devel and mecab-ipadic via dnf to use v1.5.2dev0. Is this expected behavior? |
|
Here's my full error message when I try to install: (deletemevenv) ➜ ~ python --version
Python 3.14.0
(deletemevenv) ➜ ~ pip install fugashi==1.5.2.dev0
Collecting fugashi==1.5.2.dev0
Using cached fugashi-1.5.2.dev0.tar.gz (339 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [22 lines of output]
Traceback (most recent call last):
File "/Users/joshuahamilton/deletemevenv/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
main()
~~~~^^
File "/Users/joshuahamilton/deletemevenv/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
json_out["return_val"] = hook(**hook_input["kwargs"])
~~~~^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/joshuahamilton/deletemevenv/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel
return hook(config_settings)
File "/private/var/folders/y7/tmd7mp4x6f39ll67bxp7djcr0000gn/T/pip-build-env-5rjrny1v/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 331, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/private/var/folders/y7/tmd7mp4x6f39ll67bxp7djcr0000gn/T/pip-build-env-5rjrny1v/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires
self.run_setup()
~~~~~~~~~~~~~~^^
File "/private/var/folders/y7/tmd7mp4x6f39ll67bxp7djcr0000gn/T/pip-build-env-5rjrny1v/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 317, in run_setup
exec(code, locals())
~~~~^^^^^^^^^^^^^^^^
File "<string>", line 14, in <module>
File "/private/var/folders/y7/tmd7mp4x6f39ll67bxp7djcr0000gn/T/pip-install-dqu2jb96/fugashi_29915b5a9c0047f7a01bfab5f4385eed/fugashi_util.py", line 68, in check_libmecab
raise RuntimeError("Could not configure working env. Have you installed MeCab?")
RuntimeError: Could not configure working env. Have you installed MeCab?
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip. |
Wheels were not actually being build except for Windows.
It looks like this will raise the supported Python versions
|
Thank you for the reports. It looks like the 3.14 wheels were not actually built, except on Windows. I had to update cibuildwheel and Cython, but this seems to be working for me locally now. The new version for testing is |
|
Alright, I went and tested this on both my mac and on ubuntu through my jreadability package and it works! On macos: (venv) ➜ jreadability git:(python-3.14) sw_vers
ProductName: macOS
ProductVersion: 26.0.1
BuildVersion: 25A362
(venv) ➜ jreadability git:(python-3.14) python --version
Python 3.14.0
(venv) ➜ jreadability git:(python-3.14) pip show fugashi
Name: fugashi
Version: 1.5.2.dev3
Summary: Cython MeCab wrapper for fast, pythonic Japanese tokenization.
Home-page:
Author:
Author-email: Paul O'Leary McCann <polm@dampfkraft.com>
License-Expression: MIT AND BSD-3-Clause
Location: /Users/joshuahamilton/open-source/jreadability/venv/lib/python3.14/site-packages
Requires:
Required-by: jreadability
(venv) ➜ jreadability git:(python-3.14) pytest
==================================== test session starts ====================================
platform darwin -- Python 3.14.0, pytest-8.4.2, pluggy-1.6.0
rootdir: /Users/joshuahamilton/open-source/jreadability
configfile: pyproject.toml
plugins: cov-7.0.0
collected 7 items
tests/test_jreadability.py ....... [100%]
===================================== 7 passed in 2.36s =====================================On ubuntu through gh actions: joshdavham/jreadability#15 ...and I don't have a windows machine, but it sounds like you've tested it there 👍 I think it's good for a release! |
|
v1.5.2dev3 worked fine with Python 3.14.0 on Fedora 43 Beta using Tagger. |
|
Thank you both for the confirmation, I will make an official release shortly. |
|
This is now available as v1.5.2. |
This should fix #113.
I am making a release of
v1.5.2dev0which can be used for testing. If that's OK, I'll make an official release.