perf: Move literal group_by keys out of grouping#27325
Open
gab23r wants to merge 1 commit intopola-rs:mainfrom
Open
perf: Move literal group_by keys out of grouping#27325gab23r wants to merge 1 commit intopola-rs:mainfrom
gab23r wants to merge 1 commit intopola-rs:mainfrom
Conversation
gab23r
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
orlp and
ritchie46
as code owners
github-actions
bot
added
performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22623
This optimization moves literal columns outside of the group_by. If the the group_by keys contains only literals it becomes a select.
Do we want to create a new flag to pilot this optimization ?
I used AI and I carefully review and think this it is correct.