Skip to content

fix(python): Correctly parse nested optional type in DataType.from_python #27323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gab23r wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(python): Correctly parse nested optional type in DataType.from_python #27323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions py-polars/src/polars/datatypes/_parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ def _parse_generic_into_dtype(input: Any) -> PolarsDataType:
_raise_on_invalid_dtype(input)

inner_type = inner_types[0]
if isinstance(inner_type, UnionType) or get_origin(inner_type) is Union:
return _parse_union_type_into_dtype(input)
inner_dtype = parse_py_type_into_dtype(inner_type)
return List(inner_dtype)

Expand Down
2 changes: 1 addition & 1 deletion py-polars/tests/unit/datatypes/test_datatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def test_dtypes_hashable() -> None:

@pytest.mark.parametrize(
"python_type",
[int, int | None, Optional[int], Union[int, None]], # noqa: UP007,UP045
[int, int | None, Optional[int], Union[int, None], list[Optional[int]]], # noqa: UP007,UP045
)
def test_inference_from_python_type(python_type: Any) -> None:
polars_type = pl.DataType.from_python(python_type)
Expand Down
Loading