Conversation
|
@alexander-beedie, curious about your thoughts as you already think about adding this selectors ! |
|
I would personally be quite uncomfortable with such a two-phase approach specifically for this selector. Like, how would this work at other places that are not For |
|
I battle test it more and you were right, I had some bugs with selectors athimetics, I fixed them but now the logic starts to be quite messy... I will try to revisit using the already existing |
|
I now use the already existing |
|
@coastalwhite, maybe you wanted the logic to happen before I have battle test the implemention with other context than select or with_columns and I don't see issue and I can't imagine any potential futures bugs. But maybe you have more precise ideas where bug can show up here ? I have added the |
Towards #12067
Add
cs.remaining()selector that selects columns whose output names are not produced by other expressions in the sameselect()orwith_columns()call.Example:
The implementation uses a two-pass approach in
rewrite_projections:Selector::Remaining→Selector::Wildcard - Selector::ByName(output_names)I used AI to explore different implementations and I confirm that I have reviewed all changes myself, and I believe they are relevant and correct.