Skip to content

perf: Add streaming support for grouped AsOf join#27293

Merged
ritchie46 merged 28 commits intopola-rs:mainfrom
dsprenkels:asof-join-by
Apr 15, 2026
Merged

perf: Add streaming support for grouped AsOf join#27293
ritchie46 merged 28 commits intopola-rs:mainfrom
dsprenkels:asof-join-by

Conversation

@dsprenkels
Copy link
Copy Markdown
Collaborator

@dsprenkels dsprenkels commented Apr 13, 2026

Fixes: #26500

Related issue: #20947

🤖 I did use copilot/claude quite a lot, but I have reviewed everything.

@github-actions github-actions bot added A-streaming Related to the streaming engine performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 13, 2026
@dsprenkels dsprenkels marked this pull request as ready for review April 14, 2026 08:09
Copy link
Copy Markdown
Member

@orlp orlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one nit.


#[derive(Debug)]
struct AsOfJoinParams {
_output_schema: SchemaRef,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover unused param?

@dsprenkels dsprenkels requested a review from orlp April 15, 2026 14:05
@ritchie46 ritchie46 merged commit 4b216a8 into pola-rs:main Apr 15, 2026
31 of 32 checks passed
@ritchie46 ritchie46 added the highlight Highlight this PR in the changelog label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-streaming Related to the streaming engine highlight Highlight this PR in the changelog performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streaming implementation for grouped AsOf join

3 participants