Skip to content
/ php.core.telegram Public

Custom Trainername #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
studplus wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Custom Trainername #28

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
817fc07
add function for setting up custom trainername
studplus Sep 3, 2020
2b5e428
Update DB-column
studplus Sep 3, 2020
161af5b
added Comments
Sep 6, 2020
1b3f8e2
fix comments
Sep 6, 2020
7d31b90
cleanup commands and core
Sep 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bot/commands.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,8 @@
sendMessage($update['message']['chat']['id'], '<b>' . getTranslation('not_supported') . '</b>');
}
}
// IF a Message type is private and there is no leading '/'
Copy link
Collaborator

@jinnatar jinnatar Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, we're not evaluating a command but a reply to a command?

Telegram has built in functionality for getting responses, could we not use that: https://core.telegram.org/bots/api#forcereply ?

Copy link
Member

@Chefkeks Chefkeks Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like that idea! @Artanicus
This way we would not need a trainername_time database field at all 😁

Copy link
Collaborator

@jinnatar jinnatar Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not really built for using forceReply efficiently so I'll do some plumbing in telegram/functions.php to generalize the $inline_keyboard to a $reply_markup array.

else if($update['message']['chat']['type'] == 'private'){
// Get Message from User sent to Bot and check what to do
evaluate_priv_message($update);
Copy link
Collaborator

@jinnatar jinnatar Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this function is not available in this project this will fail if not implemented in all bots dependent on the core. evaluate_priv_message sounds like functionality that should live in the core, but then that can discover handlers set by individual bots. It's a bit more work but should enable way better features in the future. :-)

}