feat: add binary existence checks to isolated runners with error messages #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add meaningful error message when binary is not found for isolated runners. The isolated runners now check for binary existence before spawning and provide a clear error message if the binary is missing. Changes: - Extract checkBinaryExists function from createBinaryExistsCheck - Add commandRunner parameter to isolatedEnvRunner - Check binary existence before spawn when commandRunner is available - Add tests for binary existence check scenarios - Update wrap command to pass commandRunner to isolated runner Resolves #40 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
✅ Checks passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented binary existence checks for isolated runners that provide meaningful error messages when a binary is not found. This prevents cryptic system errors and helps users quickly identify installation issues.
Changes
checkBinaryExistsfunction insrc/utils/command-checks.tsfor reusable binary detection logicisolatedEnvRunnerto check binary existence before spawning processes whencommandRunneris availablewrapcommand to passcommandRunnerto isolated runner"<provider> binary '<binary-name>' not found. Please ensure it is installed and available on PATH."Test Results
Fixes #40