Draft
Conversation
frattezi
reviewed
Feb 1, 2026
Contributor
frattezi
left a comment
frattezi
left a comment
There was a problem hiding this comment.
Looks great, just I consider unnecessary the custom log method, also, we want to enforce the correct usage of log levels (info, warn, error, debug) as it semantically makes more sense than all logging being a customLogger
|
|
||
| constructor() { | ||
| this.findOrCreateUserDirectory(this.uploadsDir); | ||
| console.log('uploadsDir', this.uploadsDir); |
Contributor
There was a problem hiding this comment.
Update this using your logger
|
|
||
| @Injectable({ scope: Scope.TRANSIENT }) | ||
| export class AppLogger extends ConsoleLogger { | ||
| customLog(message: string, meta?: LogMeta) { |
Contributor
There was a problem hiding this comment.
We don't need a customLog as of now. by extending the ConsoleLogger we already get all normal methods out of the box.
server/src/users/users.service.ts
Outdated
|
|
||
| async get(): Promise<User[]> { | ||
| return this.prisma.user.findMany(); | ||
| this.logger.customLog('Listing users', { |
Contributor
There was a problem hiding this comment.
Instead of customLog, use general log methods like info here
server/src/users/users.service.ts
Outdated
| return saved; | ||
| } catch (err) { | ||
| const message = err instanceof Error ? err.message : 'Unknown error'; | ||
| this.logger.customLog('Upsert failed', { |
Contributor
There was a problem hiding this comment.
For example here, you want to simply use this.logger.error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Descriptiom
A custom logger was implemented to standardize and structure application logs, improving traceability and observability across the system.
##Changes
[feat]: Add log examples with different criticalities.
[feat]: Created setup logger
[feat]: Block console.log
##Preview
##Close #5