Conversation
…ssary commas and adjusting join syntax
…method for retrieving SQLite pragma values
…mproved performance
…tead of formatted sizes
…s for improved performance
andyoknen
changed the title
…n for package building
… package building
…n before running tests
…rage path handling in SQLiteDatabase
…or PocketnetCore application
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling the SocialRegistry table rebuild function from the main thread causes the logic to fail if the height of the ChainActive internal object does not match the height of the sqlite database.
This leads to the creation of incorrect blocks.
One of the reasons for node failures may be the obscenely high memory usage of the sqlite database. The reason for the high memory consumption is the incorrect use of the cache_size pragma. This pragma is set for each database connection (which can be quite a lot when the public interface is enabled - api=1).
These changes change the behavior of using the pragma so that the specified cache size value is not multiplied by the number of database connections, but distributed among them.