Fix URL-decoding of file:// URI paths in _resolve_model_path()#65
Closed
Copilot wants to merge 1 commit intoopenstudio_mcpfrom
Closed
Fix URL-decoding of file:// URI paths in _resolve_model_path()#65Copilot wants to merge 1 commit intoopenstudio_mcpfrom
Copilot wants to merge 1 commit intoopenstudio_mcpfrom
Conversation
Open
Copilot
AI
changed the title
[WIP] WIP address feedback from PR #63 on mcp demo implementation
Fix URL-decoding of file:// URI paths in _resolve_model_path()
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_resolve_model_path()usedurlparse(...).pathdirectly without decoding percent-encoded characters, causingPath.exists()to fail for URIs with spaces or other special characters (e.g.,file:///my%20models/foo.osm).Changes
openstudio_mcp_server/server.py: Addedunquoteto theurllib.parseimport and applied it to the parsed path before constructingPath:This ensures paths generated by
Path(...).as_uri()(which percent-encodes characters) round-trip correctly back to a valid filesystem path.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.