Add two features: test_forces running from GUI, and calling gerbv to preview gerber#10
Open
colinoflynn wants to merge 6 commits intopmonta:masterfrom
Open
Add two features: test_forces running from GUI, and calling gerbv to preview gerber#10colinoflynn wants to merge 6 commits intopmonta:masterfrom
colinoflynn wants to merge 6 commits intopmonta:masterfrom
Conversation
Owner
|
Thanks---sorry to get back to you so late; the holidays were crazy busy. This all looks fine; before I merge it I just have one question: is there a reason for the "os.name=='nt'" test in show_gerber()? The code looks platform-independent, so it might be reasonable to omit the test and check for the existence of gerbv and pstoedit on every platform, not just Windows. |
Author
|
Oops... copy-paste error I think! Let me try and push a fix... |
Author
|
Test on Windows this seems to work fine anyway, but should work on Linux too - I don't have this setup on Linux, not sure if you can easily test? If not will try to install the required tools onto my Linux box later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes